Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement: agent interface information #329

Merged
merged 6 commits into from
May 13, 2024
Merged

Re-implement: agent interface information #329

merged 6 commits into from
May 13, 2024

Conversation

Tinyblargon
Copy link
Collaborator

Make

  • Reworked json unmarshaling, (it was the only place in the code base that was done differently).
  • Made code testable.
  • made code part of the VmRef struct.

Fixes #328

Will make a pull to fix this in terraform as well.

@Tinyblargon Tinyblargon added the type/enhancement An improvement of existing functionality label Apr 24, 2024
@Tinyblargon Tinyblargon requested a review from mleone87 April 24, 2024 10:11
@Tinyblargon Tinyblargon self-assigned this Apr 24, 2024
@Tinyblargon Tinyblargon merged commit 8ecac06 into Telmate:master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mleone87 mleone87 Awaiting requested review from mleone87

Assignees

@Tinyblargon Tinyblargon

Labels
type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-implement: agent interface information
1 participant
@Tinyblargon